Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jul 25, 2025

This PR renames two diagnostic command line options to follow proper kebab case naming convention:

  • --diagnostic-filelogger-synchronouswrite--diagnostic-synchronous-write
  • --diagnostic-output-fileprefix--diagnostic-file-prefix

Changes Made

  • Updated constant values in PlatformCommandLineProvider.cs
  • Updated all test files that reference these option names in assertions and integration tests
  • All command line parsing, validation, and help generation automatically use the new names through the constants

Files Modified

  • src/Platform/Microsoft.Testing.Platform/CommandLine/PlatformCommandLineProvider.cs - Updated option name constants
  • test/IntegrationTests/MSTest.Acceptance.IntegrationTests/HelpInfoTests.cs - Updated help output assertions
  • test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoTests.cs - Updated help output assertions
  • test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/DiagnosticTests.cs - Updated integration test commands

Breaking Change

This is a breaking change to the command line interface. Users will need to update their scripts and documentation to use the new option names.

Fixes #3630.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI changed the title [WIP] Rename diagnostic options to use kebab case Rename diagnostic options to use kebab case Jul 25, 2025
Copilot AI requested a review from Evangelink July 25, 2025 08:39
@Evangelink Evangelink marked this pull request as ready for review July 25, 2025 20:52
@Evangelink Evangelink enabled auto-merge (squash) July 25, 2025 20:53
# Conflicts:
#	test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoTests.cs
# Conflicts:
#	test/Directory.Build.targets
@Evangelink Evangelink changed the base branch from main to rel/4.0 July 30, 2025 13:27
@Evangelink Evangelink merged commit e490471 into rel/4.0 Jul 30, 2025
8 checks passed
@Evangelink Evangelink deleted the copilot/fix-3630 branch July 30, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename diagnostic options to use kebab case

3 participants