Skip to content

Cleanup TerminalTestReporter#6037

Merged
Evangelink merged 3 commits intomainfrom
dev/ygerges/cleanup-terminal
Jul 16, 2025
Merged

Cleanup TerminalTestReporter#6037
Evangelink merged 3 commits intomainfrom
dev/ygerges/cleanup-terminal

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

@Youssef1313 Youssef1313 commented Jul 15, 2025

  • ShowAssembly and ShowAssemblyStartAndComplete were always false. So cleaned it up.
  • We only ever run a single assembly. So cleaned that part up as well.
  • We always passed exitCode: null, outputData: null, errorData: null to AssemblyRunCompleted. So cleaned it up.

@Youssef1313 Youssef1313 marked this pull request as draft July 15, 2025 18:18
@Youssef1313 Youssef1313 force-pushed the dev/ygerges/cleanup-terminal branch from 9f12db7 to 1a9131e Compare July 15, 2025 18:19
@Youssef1313 Youssef1313 marked this pull request as ready for review July 15, 2025 18:42
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 87.69231% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.87%. Comparing base (15fe99f) to head (1a9131e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...form/OutputDevice/Terminal/TerminalTestReporter.cs 85.71% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6037      +/-   ##
==========================================
+ Coverage   73.35%   75.87%   +2.52%     
==========================================
  Files         615      615              
  Lines       37657    37512     -145     
==========================================
+ Hits        27623    28464     +841     
+ Misses      10034     9048     -986     
Flag Coverage Δ
Debug 75.87% <87.69%> (+2.52%) ⬆️
integration 75.87% <87.69%> (+2.52%) ⬆️
production 75.87% <87.69%> (+2.52%) ⬆️
unit 75.87% <87.69%> (+2.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tputDevice/Terminal/TerminalTestReporterOptions.cs 100.00% <ø> (ø)
...ting.Platform/OutputDevice/TerminalOutputDevice.cs 84.14% <100.00%> (+4.25%) ⬆️
...form/OutputDevice/Terminal/TerminalTestReporter.cs 90.83% <85.71%> (+12.00%) ⬆️

... and 66 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Evangelink Evangelink enabled auto-merge (squash) July 16, 2025 07:13
@Evangelink Evangelink merged commit 6dd3645 into main Jul 16, 2025
8 checks passed
@Evangelink Evangelink deleted the dev/ygerges/cleanup-terminal branch July 16, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants