Skip to content

Bump analyzers to warning #5860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Evangelink merged 7 commits into from
Jun 25, 2025
Merged

Bump analyzers to warning #5860

Evangelink merged 7 commits into from
Jun 25, 2025

Conversation

@Evangelink
Copy link
Member

@Evangelink Evangelink commented Jun 23, 2025 •
edited by Youssef1313
Loading

Fixes #5748

Related to #1285

@Evangelink
Bump analyzers to warning
d0fadd0
@Evangelink
Merge branch 'dev/v4' into dev/amauryleve/analyzers
adc95f9 
# Conflicts:
#	src/Analyzers/MSTest.Analyzers/UseAttributeOnTestMethodAnalyzer.cs
Youssef1313
Youssef1313 reviewed Jun 24, 2025
View reviewed changes
@Youssef1313 Youssef1313 linked an issue Jun 24, 2025 that may be closed by this pull request
[v4][Breaking] Review analyzer serverities #5748
Closed
Youssef1313
Youssef1313 reviewed Jun 24, 2025
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test VerifyMSTestAnalysisModeForDifferentAnalyzers needs to replace MSTEST0017 with some other analyzer which is info + enabled by default

Youssef1313
Youssef1313 reviewed Jun 24, 2025
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we miss UseCooperativeCancellationForTimeoutAnalyzer? Or did we intentionally not bump to warning?

@Youssef1313
Copy link
Member

Youssef1313 commented Jun 24, 2025

NOTE: The analyzers that are still info+enabled in this PR are:

  • MSTEST0016: Test class should have test method
  • MSTEST0039: Use newer methods to assert exceptions
    • As we are planning to remove the old Assert.ThrowsException APIs, this won't be relevant and we will remove the analyzer.
  • MSTEST0045: Use 'CooperativeCancellation = true' with '[Timeout]'
    • I'm not sure if it's intentional to remain info.

So, for the VerifyMSTestAnalysisModeForDifferentAnalyzers, our only option to replace MSTEST0017 would be MSTEST0016.

Youssef1313
Youssef1313 reviewed Jun 25, 2025
View reviewed changes
@Youssef1313 Youssef1313 added this to the 4.0.0 milestone Jun 25, 2025
@Evangelink Evangelink merged commit 094757f into microsoft:dev/v4 Jun 25, 2025
9 checks passed
@Evangelink Evangelink deleted the dev/amauryleve/analyzers branch June 25, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Youssef1313 Youssef1313 Youssef1313 approved these changes

Assignees

No one assigned

Labels

Breaking ‼️

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

[v4][Breaking] Review analyzer serverities

2 participants

@Evangelink @Youssef1313