Skip to content

Remove ClassCleanupBehavior #5827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Youssef1313 merged 7 commits into from
Jun 20, 2025
Merged

Remove ClassCleanupBehavior #5827

Youssef1313 merged 7 commits into from
Jun 20, 2025

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jun 19, 2025 •
edited
Loading

Closes #1316
Closes #1574
Related to #1285

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/classcleanup branch from 8d230bf to 076822e Compare June 19, 2025 11:14
@Youssef1313
Copy link
Member Author

Youssef1313 commented Jun 19, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 19, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/classcleanup branch 2 times, most recently from a1b57fd to 7d89dae Compare June 19, 2025 12:23
Evangelink
Evangelink reviewed Jun 19, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop analyzer + codefix related to that

@Youssef1313
Copy link
Member Author

Youssef1313 commented Jun 19, 2025

I think we can drop analyzer + codefix related to that

@Evangelink it's already dropped, unless there is something I'm missing

@Evangelink
Copy link
Member

Evangelink commented Jun 19, 2025

I think we can drop analyzer + codefix related to that

@Evangelink it's already dropped, unless there is something I'm missing

I missed the file while browsing deletions, please also "deprecate" (comment out) the related diagnostic ID.

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/classcleanup branch from 7d89dae to 40cf630 Compare June 19, 2025 13:15
@Youssef1313 Youssef1313 force-pushed the dev/ygerges/classcleanup branch from 40cf630 to 16b0ca3 Compare June 19, 2025 14:17
@Youssef1313 Youssef1313 force-pushed the dev/ygerges/classcleanup branch from 2f23397 to 7ec9e0d Compare June 19, 2025 16:10
This was linked to issues Jun 19, 2025
Change ClassCleanup default behavior to be "EndOfClass" #1316
Closed
Remove ClassCleanupBehavior.EndOfAssembly #1574
Closed
@Youssef1313 Youssef1313 mentioned this pull request Jun 19, 2025
Closed
65 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the Area: MSTest Issues with MSTest that are not specific to more refined area (e.g. analyzers or assertions) label Jun 20, 2025
@Youssef1313
Copy link
Member Author

Youssef1313 commented Jun 20, 2025

@mariam-abdulla Can you please look into ValidateTestRunLifecycle test (and related test assets) to adjust for the breaking change here?

For context, ClassCleanupBehavior.EndOfAssembly was previously the default. With this PR, EndOfAssembly is removed completely, and we only have EndOfClass now.

@Youssef1313 Youssef1313 merged commit f66ff43 into dev/v4 Jun 20, 2025
8 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/classcleanup branch June 20, 2025 18:28
@Youssef1313 Youssef1313 added this to the 4.0.0 milestone Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees

No one assigned

Labels

Area: MSTest Issues with MSTest that are not specific to more refined area (e.g. analyzers or assertions) Breaking ‼️

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

Remove ClassCleanupBehavior.EndOfAssembly Change ClassCleanup default behavior to be "EndOfClass"

3 participants

@Youssef1313 @Evangelink