Skip to content

Use some raw strings#2973

Merged
Evangelink merged 10 commits intomicrosoft:mainfrom
SimonCropp:use-some-raw-strings
May 28, 2024
Merged

Use some raw strings#2973
Evangelink merged 10 commits intomicrosoft:mainfrom
SimonCropp:use-some-raw-strings

Conversation

@SimonCropp
Copy link
Copy Markdown
Contributor

@SimonCropp SimonCropp commented May 27, 2024

No description provided.

@SimonCropp SimonCropp requested a review from Evangelink as a code owner May 27, 2024 01:37
Evangelink
Evangelink previously approved these changes May 27, 2024
View reviewed changes
@Evangelink Evangelink enabled auto-merge (squash) May 27, 2024 13:22
Evangelink
Evangelink previously approved these changes May 27, 2024
View reviewed changes
@Evangelink Evangelink mentioned this pull request May 27, 2024
Closed
@SimonCropp
Copy link
Copy Markdown
Contributor Author

SimonCropp commented May 28, 2024

any ideas what test is failing? i cant see the results in devops

@Evangelink
Copy link
Copy Markdown
Member

Evangelink commented May 28, 2024

any ideas what test is failing? i cant see the results in devops

Here is the issue:

Error:
Error during test: Verification failed for Config must have OM redirection at line 59 of method 'SetConfigurationFileShouldSetOMRedirectionIfConfigFileIsPresent' in file '/_/test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Utilities/AppDomainUtilitiesTests.cs'.

Stack trace:
   at TestFramework.ForTestingMSTest.TestContainer.Throw(String expression, String caller, String filePath, Int32 lineNumber) in /_/test/Utilities/TestFramework.ForTestingMSTest/TestContainer.cs:line 97
   at TestFramework.ForTestingMSTest.TestContainer.Verify(Boolean condition, String expression, String caller, String filePath, Int32 lineNumber) in /_/test/Utilities/TestFramework.ForTestingMSTest/TestContainer.cs:line 62
   at MSTestAdapter.PlatformServices.UnitTests.Utilities.AppDomainUtilitiesTests.SetConfigurationFileShouldSetOMRedirectionIfConfigFileIsPresent() in /_/test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Utilities/AppDomainUtilitiesTests.cs:line 59

I'll see if I repro locally and fix it.

@Evangelink Evangelink merged commit 2f0f814 into microsoft:main May 28, 2024
@SimonCropp
Copy link
Copy Markdown
Contributor Author

SimonCropp commented May 28, 2024

@Evangelink thanks

@SimonCropp SimonCropp deleted the use-some-raw-strings branch May 28, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SimonCropp @Evangelink