Skip to content

Consider renaming ConditionBaseAttribute.ShouldRun to IsConditionMet/IsConditionSatisfied #6086

@Youssef1313

Description

@Youssef1313

The current name ShouldRun may indicate that the implementation should take into account ConditionMode (Include vs Exclude). But in fact, the implementation shouldn't check the ConditionMode as the adapter itself inverts the ShouldRun based on ConditionMode.

The API seems to be confusing on its current form.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: MSTestIssues with MSTest that are not specific to more refined area (e.g. analyzers or assertions)Breaking ‼️

    Type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions