-
Notifications
You must be signed in to change notification settings - Fork 291
Closed
Labels
Area: MSTestIssues with MSTest that are not specific to more refined area (e.g. analyzers or assertions)Issues with MSTest that are not specific to more refined area (e.g. analyzers or assertions)Breaking ‼️
Milestone
Description
This issue serves as a proposal for changes related to attributes and how we do the reflection.
-
ALL calls to
GetCustomAttributesshould useinherit: true. -
Attributes that are not inheritable (e.g, TestClassAttribute), will have
Inherited = falsein their attribute usage.
This means two things:- Even if we use
inherit: true, they are not inherited because of the attribute usage. - Users are allowed to introduce a new attribute,
class MyTestClassAttribute : TestClassAttributethat has AttributeUsage withInherited = true, in that case, we allow inheritance, as it's explicitly stated by the user.
- Even if we use
More changes may be needed to have better and consistent experience, but this may be a good first step aimed for v4
cc @Evangelink
Metadata
Metadata
Assignees
Labels
Area: MSTestIssues with MSTest that are not specific to more refined area (e.g. analyzers or assertions)Issues with MSTest that are not specific to more refined area (e.g. analyzers or assertions)Breaking ‼️