Skip to content

Change TAEF nuget package to use new Microsoft.Taef name; Update to 10.58 release build version.#9656

Merged
2 commits merged intomainfrom
dev/miniksa/taef_update
Mar 30, 2021
Merged

Change TAEF nuget package to use new Microsoft.Taef name; Update to 10.58 release build version.#9656
2 commits merged intomainfrom
dev/miniksa/taef_update

Conversation

@miniksa
Copy link
Member

@miniksa miniksa commented Mar 30, 2021

Change TAEF nuget package to use new Microsoft.Taef name; Update to 10.58 release build version.

PR Checklist

  • Closes email from Phil letting us know TAEF has a new release build and a rename.
  • Closes annoying duplicate TAEF import warning in Parser.UnitTests.vcxproj
  • I work here.
  • Need to see the tests run off CI to confirm this is fine for those environments and Helix

Validation Steps Performed

  • Build/run tests locally
  • Build/run unit and feature tests in CI
  • Build/run Helix-lab tests in CI

@miniksa miniksa added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Meta The product is the management of the products. Issue-Task It's a feature request, but it doesn't really need a major design. labels Mar 30, 2021
@miniksa miniksa self-assigned this Mar 30, 2021
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 30, 2021
@ghost
Copy link

ghost commented Mar 30, 2021

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit c7d2a81 into main Mar 30, 2021
@ghost ghost deleted the dev/miniksa/taef_update branch March 30, 2021 10:58
@zadjii-msft
Copy link
Member

zadjii-msft commented Mar 30, 2021

oh no, did we build/run the local tests locally? Or have they been broken even longer than this morning?

@zadjii-msft
Copy link
Member

zadjii-msft commented Mar 30, 2021 •
edited
Loading

Oh, no, they were broken even before this. Welp. looks like I'll be fruitlessly trying to bisect that today.

It was definitely defterm

@DHowett
Copy link
Member

DHowett commented Mar 30, 2021

I was just running them locally with the old taef as well, and they do somewhat fail to do tab things.

@zadjii-msft zadjii-msft mentioned this pull request Mar 30, 2021
Closed
3 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees

@miniksa miniksa

Labels

Area-Build Issues pertaining to the build system, CI, infrastructure, meta AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miniksa @zadjii-msft @DHowett