Fix build break where Microsoft.Terminal.Control.dll is empty#9537
Merged
3 commits merged intomainfrom Mar 18, 2021
Merged
Conversation
DHowett
approved these changes
Mar 18, 2021
Member
Author
|
@msftbot merge this in 1 minute |
|
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
miniksa
approved these changes
Mar 18, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIL that the
<None Include="Foo.def" />line in our projects isactually totally meaningless. The important line is the one that's in
cppwinrt.build.pre.props, where we declareSo if you change a project's name, and not the
.deffile, then thelinker will just not use the
.deffile at all.More importantly, this seemingly doesn't matter in debug builds. In a
Debug build, the linker will happily still include
WINRT_CanUnloadNowand
WINRT_GetActivationFactoryin the exports from the dll, evenwithout the
.def. But in a Release build, the linker is much moreagressive about pruning symbols that aren't referenced, and without
those two, NONE of the symbols are eventually referenced.
This PR fixes
Microsoft.Terminal.Controlby renaming the.def, andmakes it marginally harder for someone to make the same mistake in the
future.
References
Microsoft.Terminal.TerminalControlto.Control; Split into dll & lib #9472PR Checklist
mainis horked, bought farm, etc. #9529