Fix #8458: Handle all Ctrl-key combinations#8870
Merged
1 commit merged intomicrosoft:mainfrom Feb 2, 2021
lhecker:issue-8458-more-ctrl-combinations
Merged
Fix #8458: Handle all Ctrl-key combinations#88701 commit merged intomicrosoft:mainfrom lhecker:issue-8458-more-ctrl-combinations
1 commit merged intomicrosoft:mainfrom
lhecker:issue-8458-more-ctrl-combinations
Conversation
lhecker
commented
Jan 24, 2021
zadjii-msft
approved these changes
Jan 25, 2021
Member
zadjii-msft
left a comment
There was a problem hiding this comment.
God why is input such a disaster 🙃
Thanks for looking into this and fixing it
Member
Author
|
It might take me until next weekend to fix the failing unit tests by the way. |
Member
Author
|
Turns out there was a reason why |
|
Hello @miniksa! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Ctrl+\ produces
^\using the US keyboard layout, thanks to Ctrl-key mappings inside the keyboard layout, whereas some layouts, like the UK extended layout, don't contain those. This causes the character value to be zero and previously caused no VT sequence to be generated under these situations. This PR employsMapVirtualKeyWto infer the missing characters.As a side effect this PR effectively causes all major keys on the keyboard to produce Ctrl+combinations now.
PR Checklist
Validation Steps Performed
Compared all major keys in combination with Ctrl with the app store version of Terminal using
showkeyin WSL. All keys that previously worked still appear to continue to work.