dx: don't check the OS version multiple times#3480
Merged
DHowett-MSFT merged 1 commit intomicrosoft:masterfrom Nov 8, 2019
Merged
dx: don't check the OS version multiple times#3480DHowett-MSFT merged 1 commit intomicrosoft:masterfrom
DHowett-MSFT merged 1 commit intomicrosoft:masterfrom
Conversation
zadjii-msft
approved these changes
Nov 8, 2019
Member
zadjii-msft
left a comment
There was a problem hiding this comment.
Yea this looks simple enough to me. Thanks!
Member
We recently added the WPF version of the TermControl (in #2004). That control isn't used in the Windows Terminal, but does share a lot of code (including the DXRenderer). It's not necessarily bound to the same Windows 10 requirement that the rest of the Terminal is 😄 |
DHowett-MSFT
approved these changes
Nov 8, 2019
Contributor
DHowett-MSFT
left a comment
There was a problem hiding this comment.
Yeah, I guess the OS version won't be changing at runtime eh?
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
A tiny little perf fix.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
I don't really get it, though. Isn't Windows Terminal only available on Windows 10+?
Validation Steps Performed