Polish GenerateSettingsIndex.ps1 and propagate changes#19907
Merged
carlos-zamora merged 3 commits intomainfrom Feb 26, 2026
Merged
Polish GenerateSettingsIndex.ps1 and propagate changes#19907carlos-zamora merged 3 commits intomainfrom
carlos-zamora merged 3 commits intomainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
DHowett
reviewed
Feb 26, 2026
| "Microsoft::Terminal::Settings::Editor::Launch" = @{ | ||
| ResourceName = "Nav_Launch/Content" | ||
| NavigationParam = "Launch_Nav" | ||
| SubPage = "BreadcrumbSubPage::None" |
Member
There was a problem hiding this comment.
nit: you could also leave this off and default it to None if it is not present
| #include <LibraryResources.h> | ||
|
|
||
| // In Debug builds, USES_RESOURCE() expands to a lambda (for resource validation), | ||
| // which prevents constexpr evaluation. In Release it's a no-op identity macro. |
| return entries; | ||
| } | ||
|
|
||
| const std::array<IndexEntry, $($profileEntries.Count)>& LoadProfileIndex() |
Member
There was a problem hiding this comment.
because you are just returning the array directly, you can make this auto and not have to ever repeat the type again
Suggested change
| const std::array<IndexEntry, $($profileEntries.Count)>& LoadProfileIndex() | |
| const auto& LoadProfileIndex() |
This comment has been minimized.
This comment has been minimized.
DHowett
approved these changes
Feb 26, 2026
DHowett
approved these changes
Feb 26, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Cleans up GenerateSettingsIndex.ps1 by addressing the feedback Dustin left in #19519
Validation Steps Performed
✅ SUI search works