Remove the suggestion chosen handler from EditAction's ShortcutActionBox#19906
Merged
carlos-zamora merged 1 commit intomainfrom Feb 25, 2026
Merged
Remove the suggestion chosen handler from EditAction's ShortcutActionBox#19906carlos-zamora merged 1 commit intomainfrom
carlos-zamora merged 1 commit intomainfrom
Conversation
carlos-zamora
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
There is an issue where clicking an item (with the mouse) from the auto suggest box's dropdown would fail on the first try, but the dropdown gets reopened automatically and clicking an item after that works. This is because
AutoSuggestBoxhasUpdateTextOnSelectdefaulted toTrue, but we also have aSuggestionChosenhandler that effectively does the same thing, and the two were conflicting. This commit fixes that by removing ourSuggestionChosenhandler.Verification steps performed
Selecting an item from the dropdown with mouse works on first try. Keyboard flow continues to work as expected.