Skip to content

Show additional keybinding count if there are additional keybindings on the top-level Actions page#19865

Merged
DHowett merged 5 commits intomainfrom
dev/pabhoj/actions_editor_top_level_keybinds
Feb 13, 2026
Merged

Show additional keybinding count if there are additional keybindings on the top-level Actions page#19865
DHowett merged 5 commits intomainfrom
dev/pabhoj/actions_editor_top_level_keybinds

Conversation

@PankajBhojwani
Copy link
Contributor

Summary of the Pull Request

On the top-level actions page, display an indicator if there are additional keybindings other than the one displayed

Validation Steps Performed

Screenshot below

PR Checklist

@PankajBhojwani PankajBhojwani changed the title show additional keybinding count if there are additional keybindings Show additional keybinding count if there are additional keybindings Feb 13, 2026
@PankajBhojwani
Copy link
Contributor Author

image

@PankajBhojwani
Copy link
Contributor Author

@carlos-zamora Thoughts on the automation prop name with this change? Narrator now reads "Copy text, ctrl+insert, +2" for example and I'm not entirely sure if that makes sense

@PankajBhojwani PankajBhojwani changed the title Show additional keybinding count if there are additional keybindings Show additional keybinding count if there are additional keybindings on the top-level Actions page Feb 13, 2026
@DHowett
Copy link
Member

DHowett commented Feb 13, 2026

(can we not say something like "+2 more" in the UI and "and 2 more" in the voiceover?)

@DHowett
Copy link
Member

DHowett commented Feb 13, 2026

... hmm. can we make it so that the tooltip for the +2 lists them?

@carlos-zamora
Copy link
Member

@carlos-zamora Thoughts on the automation prop name with this change? Narrator now reads "Copy text, ctrl+insert, +2" for example and I'm not entirely sure if that makes sense

Yeah, I think hearing the "+" is a bit of a weird experience since we're already reading out the +'s as a part of the key bindings. I like Dustin's idea.

@PankajBhojwani
Copy link
Contributor Author

Tooltip screenshot:
image

@github-actions

This comment has been minimized.

@DHowett
Copy link
Member

DHowett commented Feb 13, 2026

code format is upset, but otherwise you can ignore the arm64 failure

@DHowett DHowett merged commit 83b9569 into main Feb 13, 2026
18 of 20 checks passed
@DHowett DHowett deleted the dev/pabhoj/actions_editor_top_level_keybinds branch February 13, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't see all key bindings (or indication that there _are_ many keybindings) for actions in new editor

3 participants