Skip to content

vcpkg: move to jsoncpp 1.9.6, import an upstream whitespace patch#19836

Merged
DHowett merged 3 commits intomainfrom
dev/duhowett/jsoncpp-whitespace-patch
Feb 9, 2026
Merged

vcpkg: move to jsoncpp 1.9.6, import an upstream whitespace patch#19836
DHowett merged 3 commits intomainfrom
dev/duhowett/jsoncpp-whitespace-patch

Conversation

@DHowett
Copy link
Member

@DHowett DHowett commented Feb 6, 2026

The maintainers of jsoncpp chose to decline open-source-parsers/jsoncpp#1154 until they make a new major release.
We are not burdened by that requirement.

Closes #10887
Refs #19834

@DHowett
Copy link
Member Author

DHowett commented Feb 6, 2026

To review only the changes needed to import the patch, see 826aeab

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Settings Issues related to settings and customizability, for console or terminal Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Feb 6, 2026
@DHowett
Copy link
Member Author

DHowett commented Feb 6, 2026

I bet it makes all our tests fail because they hardcode the trailing spaces ;P

@DHowett
Copy link
Member Author

DHowett commented Feb 6, 2026

Works fine, arm64 fails due to an azure devops bug. Lol.

@DHowett DHowett merged commit 8e4642d into main Feb 9, 2026
18 of 20 checks passed
@DHowett DHowett deleted the dev/duhowett/jsoncpp-whitespace-patch branch February 9, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings editor saves settings.json lines with trailing whitespace

2 participants