Use til::hstring_format wherever possible#19733
Merged
Conversation
64d3f16 to
7eb03c7
Compare
Member
|
well, the build ist broke |
DHowett
reviewed
Jan 14, 2026
| // NOTE: This will fail to compile if you pass a string literal as the first argument (the format argument). | ||
| // This is because std::forwarding literals turns them from constant expressions into regular ones. | ||
| // It can be fixed by giving the first argument an explicit type. I intentionally didn't do that | ||
| // because if you pass a string literal, you really ought to pass a FMT_COMPILE() instead. |
Member
There was a problem hiding this comment.
well, then why don't the tests use FMT_COMPILE? Since you're already here ;P
Member
Author
There was a problem hiding this comment.
Ah true I could've done that. Not using hstring when not needed seemed like a nice improvement already. :D
DHowett
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up of #19721 which added
til::hstring_format.