Fix colored tab losing color when unselected#18306
Merged
carlos-zamora merged 1 commit intomainfrom Dec 11, 2024
Merged
Conversation
Member
Author
DemoIf we don't remove the
|
lhecker
approved these changes
Dec 11, 2024
zadjii-msft
approved these changes
Dec 11, 2024
DHowett
approved these changes
Dec 11, 2024
Member
DHowett
left a comment
There was a problem hiding this comment.
I think this will fix the accent/terminalBackground issue, but I'll wait for confirmation!
Member
Author
With colored (red) tabs: Default colored tabs: Looks good to me now! I'll add it to the PR body and merge the PR 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we colored a tab, then switched to another tab, there's a bug that the unselected tab loses its color. This was introduced in PR #18109. This PR fixes that by actually applying the selected color to the tab (whoops). Additionally, I removed setting the "TabViewItemHeaderCloseButtonBackground" resource because it looked weird (see comment in PR).
Closes #18226