@microsoft-github-policy-service agree

Unfortunately, we're currently integrated with Microsoft's internal localization service and that's where our translations are coming from. I suppose in theory we could merge this, but in practice it's probably not possible because of that.

Oh, no, as long as we are not getting Serbian translations from Touchdown we can accept community contributions! We just need a process to make sure the language stays up to date as we add new text.

I can commit myself to update this localization. Certainly, I won't abandon it without ensuring a clear way forward with maintainers (@DHowett)

After giving it some thought, we decided that we should merge your PR, because having some translation is better than having none. We'd essentially put the stewardship of keeping the translation up to date into the stewardship of the community. Our UI framework (WinUI) will fall back to English or some other secondary language if a Serbian translation string is unavailable.

x-linking this to #10667. This PR seems like it's the prototypical case of "if it's not one of the automatic translations, then the community is free to add their own.

@eevan78 Is there a reason this PR is still a draft?

IIRC we have to manually list out the languages we support in either our Package.appxmanifest or... some other file. Somewhere in the settings editor, where we pick the languages? But if this works, then let's merge it

@zadjii-msft this is my first contribution to this project, and I was not completely sure if I have picked up all places with the source strings.
Hence I marked it as a draft.

Now that there is a decision to merge it, there is no need to keep it as a draft anymore. I think that I have translated everything.

Hello,
is there any progress on this?

/azp run

As a follow-up and maybe in a separate PR, you may want to play around with the language list in the Settings UI. It had to be hardcoded for annoying reasons. It's in LaunchViewModel.cpp, appLanguageTags

Thank you so much! This is our first ever non-internal language contribution. We'll need to find a way to maintain these in the future, but I'm more than happy to have this one. Sorry it took so long for us to decide on this :)

I'm also happy to be able to contribute to this excellent project!
Don't apologize, definitely this is not a high priority change. I'm glad that it was accepted!

As a follow-up and maybe in a separate PR, you may want to play around with the language list in the Settings UI. It had to be hardcoded for annoying reasons. It's in LaunchViewModel.cpp, appLanguageTags

Sure, I will do it! This is exactly what I needed from you, a hint to find all relevant places that needs to be translated. Thanks. I'll work on this and open another PR.