Show parts of the scrollback on restore#17334
Merged
zadjii-msft merged 1 commit intomainfrom May 30, 2024
Merged
Conversation
Member
|
Does this approach cause the display to snap down to the bottom when you type for the first time? |
Member
Author
|
It will already be at the bottom when you open it: If I scroll up and then type, it'll snap down to how it looks like in the screenshot. |
carlos-zamora
approved these changes
May 29, 2024
zadjii-msft
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, this makes use of
PSEUDOCONSOLE_INHERIT_CURSORto stop ConPTY from emitting a CSI 2 J on startup. Then, it usesTerminal::SetViewportPositionto fake-scroll the viewport down so that only 3 lines of scrollback are visible. It avoids printing actual newlines because if we later change the text buffer to actually track the written contents, we don't want those newlines to end up in the next buffer snapshot.Closes #17274
Validation Steps Performed