Add support for setting a profile's tab title by cinnamon-msft · Pull Request #1358 · microsoft/terminal

cinnamon-msft · 2019-06-20T23:13:58Z

Summary of the Pull Request

Added tab renaming functionality to profiles.json

References

PR Checklist

Closes Feature request: suppress VT title and prefer profile name (or something else) #608
CLA signed. If not, go over here and sign the CLA
Tests added/passed
Requires documentation to be updated
I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Added "tabTitle" : "insert title here" to a profile in the profiles.json

src/cascadia/TerminalApp/Profile.cpp

src/cascadia/TerminalApp/App.cpp

src/cascadia/TerminalSettings/TerminalSettings.cpp

src/cascadia/TerminalApp/App.cpp

src/cascadia/TerminalSettings/ICoreSettings.idl

src/cascadia/TerminalSettings/TerminalSettings.cpp

DHowett-MSFT · 2019-06-21T19:43:24Z

nit: title should be more like Add support for setting a profile's tab title

src/cascadia/UnitTests_TerminalCore/ScreenSizeLimitsTest.cpp

DHowett-MSFT · 2019-06-26T20:52:30Z

Should we name this tabTitleOverride? @oising and @Jaykul probably have an opinion

zadjii-msft

Frankly my only major comment is a nit. Nice work!

src/cascadia/TerminalApp/App.cpp

src/cascadia/TerminalApp/Profile.cpp

src/cascadia/TerminalApp/App.cpp

Co-Authored-By: Michael Niksa <miniksa@microsoft.com>

I don't agree that we need this feature, but I refuse to continue holding it up.

gregchamblin · 2019-07-03T13:56:56Z

Is this included in 0.2.1831.0 from the Windows Store? I tried to add the tabTitle to the JSON and it gets deleted every time I open the app.

zadjii-msft · 2019-07-03T16:22:31Z

@gregchamblin Nope. This one didn't make the cut.

gregchamblin · 2019-07-03T16:31:11Z

Thank you. I will watch for it in the next update.

ghost · 2019-08-03T01:48:55Z

🎉Windows Terminal Preview v0.3.2142.0 has been released which incorporates this pull request.:tada:

Handy links:

m986883511 · 2023-06-05T02:27:34Z

so how to write a commond to change my terminal title?

Jaykul · 2023-06-06T01:41:05Z

so how to write a commond to change my terminal title?

https://learn.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences#window-title

In PowerShell:

"`e]2;This is the title`a"

initial tab renaming functionality

6fdc1d9

cinnamon-msft requested review from DHowett-MSFT, adiviness, carlos-zamora, miniksa and zadjii-msft June 20, 2019 23:13

cinnamon-msft self-assigned this Jun 20, 2019

fixed formatting

10a1995

cinnamon-msft changed the title ~~initial tab renaming functionality~~ Tab Renaming Jun 20, 2019

carlos-zamora reviewed Jun 20, 2019

View reviewed changes

src/cascadia/TerminalApp/Profile.cpp Show resolved Hide resolved

src/cascadia/TerminalApp/Profile.cpp Show resolved Hide resolved

src/cascadia/TerminalApp/Profile.cpp Show resolved Hide resolved

carlos-zamora reviewed Jun 20, 2019

View reviewed changes

src/cascadia/TerminalApp/App.cpp Outdated Show resolved Hide resolved

carlos-zamora reviewed Jun 20, 2019

View reviewed changes

src/cascadia/TerminalApp/App.cpp Show resolved Hide resolved

miniksa requested changes Jun 21, 2019

View reviewed changes

src/cascadia/TerminalApp/App.cpp Outdated Show resolved Hide resolved

src/cascadia/TerminalApp/App.cpp Outdated Show resolved Hide resolved

ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 21, 2019

adiviness approved these changes Jun 21, 2019

View reviewed changes

src/cascadia/TerminalSettings/TerminalSettings.cpp Outdated Show resolved Hide resolved

DHowett-MSFT previously requested changes Jun 21, 2019

View reviewed changes

src/cascadia/TerminalApp/App.cpp Outdated Show resolved Hide resolved

src/cascadia/TerminalSettings/ICoreSettings.idl Outdated Show resolved Hide resolved

src/cascadia/TerminalSettings/TerminalSettings.cpp Outdated Show resolved Hide resolved

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 21, 2019

cinnamon-msft changed the title ~~Tab Renaming~~ Add support for setting a profile's tab title Jun 21, 2019

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 21, 2019

cleaned up code, added fixes and documentation

4d57617

DHowett-MSFT reviewed Jun 26, 2019

View reviewed changes

src/cascadia/UnitTests_TerminalCore/ScreenSizeLimitsTest.cpp Outdated Show resolved Hide resolved

removed tabTitle from mockTermSettings

dc700d7

zadjii-msft reviewed Jul 1, 2019

View reviewed changes

src/cascadia/TerminalApp/App.cpp Outdated Show resolved Hide resolved

src/cascadia/TerminalApp/Profile.cpp Outdated Show resolved Hide resolved

zadjii-msft approved these changes Jul 1, 2019

View reviewed changes

cinnamon-msft added 2 commits July 1, 2019 14:37

Merge branch 'master' into cinnamon/custom-tab-name

acbe50d

code cleanup

344ea52

miniksa reviewed Jul 1, 2019

View reviewed changes

src/cascadia/TerminalApp/App.cpp Outdated Show resolved Hide resolved

miniksa approved these changes Jul 1, 2019

View reviewed changes

Update src/cascadia/TerminalApp/App.cpp

4837e7d

Co-Authored-By: Michael Niksa <miniksa@microsoft.com>

carlos-zamora approved these changes Jul 2, 2019

View reviewed changes

cinnamon-msft merged commit c791b78 into master Jul 2, 2019

cinnamon-msft deleted the cinnamon/custom-tab-name branch July 2, 2019 17:09

DHowett-MSFT mentioned this pull request Jul 20, 2019

Feature Request: Tab bar, Title bar and App Icon styling #1994

Closed

zadjii-msft mentioned this pull request Jul 25, 2019

Feature Request: name on tabs #2092

Closed

imjasonmiller mentioned this pull request Jul 29, 2019

Mutiple opened tabs don't show properly #2134

Closed

ghost mentioned this pull request Aug 3, 2019

Feature request: suppress VT title and prefer profile name (or something else) #608

Closed

matheusfelipeog mentioned this pull request Apr 12, 2020

Rename tab title not working for WSL and Bash #5333

Closed

Conversation

cinnamon-msft commented Jun 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DHowett-MSFT commented Jun 21, 2019

Uh oh!

Uh oh!

DHowett-MSFT commented Jun 26, 2019

Uh oh!

zadjii-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregchamblin commented Jul 3, 2019

Uh oh!

zadjii-msft commented Jul 3, 2019

Uh oh!

gregchamblin commented Jul 3, 2019

Uh oh!

ghost commented Aug 3, 2019

Uh oh!

m986883511 commented Jun 5, 2023

Uh oh!

Jaykul commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

cinnamon-msft commented Jun 20, 2019 •

edited

Loading

Jaykul commented Jun 6, 2023 •

edited

Loading