Fix tab movement while running multiple actions#11144
Merged
carlos-zamora merged 1 commit intomicrosoft:mainfrom Sep 7, 2021
Merged
Fix tab movement while running multiple actions#11144carlos-zamora merged 1 commit intomicrosoft:mainfrom
carlos-zamora merged 1 commit intomicrosoft:mainfrom
Conversation
… changing tabs while running multiple actions further calls to _GetFocusedTab will return the correct one.
zadjii-msft
approved these changes
Sep 7, 2021
Contributor
Author
|
While I'd like to get this in, I just want to make sure that #11146 gets attention too since that is a larger issue (and msftbot also took a vacation this weekend) |
carlos-zamora
approved these changes
Sep 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Make sure to always synchronously set the selected tab. This way when changing tabs while running multiple actions further calls to _GetFocusedTab will return the correct one.
Edit #11146 discovered while trying to test this so while I fixed the case I wanted, things seem to be broken generally so it is hard for me to test if I broke anything else.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Ran the command specified in the issue and confirmed that the correct tab was focused and that the correct pane was zoomed.