Add support for focusPane action, focus-pane subcommand#10142
Conversation
DHowett
left a comment
There was a problem hiding this comment.
Approving contingent on the resw file thing
lhecker
left a comment
There was a problem hiding this comment.
Personally, I couldn't find any real issues. ¯\_(ツ)_/¯
| // Make sure to use _FocusFirstChild here - that'll properly update the | ||
| // focus if we're in startup. | ||
| _FocusFirstChild(); | ||
| return true; |
There was a problem hiding this comment.
If this returns, you don't need the else.
|
@msftbot merge this in 10 minutes |
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
🎉 Handy links: |
Summary of the Pull Request
Adds support for the
focusPaneaction, and thefocus-panesubcommand. These allow the user to focus a pane by it's ID.focusPaneaccepts anid, identifying the id of the pane to focus.focus-pane,fprequires the parameter--target,-tto ID the pane it's going to focus.PR Checklist
focus-panesubcommand #5464Detailed Description of the Pull Request / Additional comments
The ID isn't totally useful right now, since users can't see them. But they're there, and used in-order. This is just slightly more ergonomic for complicated commandlines than
mf up; mf leftValidation Steps Performed
Tested in command palette
Tested a variety of commandlines.
wtd -w 0 mf down ; spandwtd -w 0 fp -t 1 ; spgave me special difficulty.