Interactivity bugs post-#9820 #9955
Description
This is a tracking thread for things I probably broke in #9820. I'd rather not file 100 bugs for these
- (A) Mousedown, select, SCROLL does a weird thing with endpoints that doesn't happen in stable
- fixed in 4f4df01
- fixed in First three interactivity fixes #9980
- (B) Trackpad scrolling down with small increments seems buggy. But scrolling with a big increment goes fast? And scrolling with the mouse is fine. And trackpad scrolling in mouse mode is fine.
- (C) Looks like there's a selection issue when you click and drag too quickly. Seems like the start endpoint doesn't always get set.
- fixed in 9d33e89
- fixed in First three interactivity fixes #9980
- (D) Mysterious DX crash - this never reprod, so we're assuming it's unrelated
Mysterious DX crash
I experienced a crash when I killed DWM, and it took particularly long to recover
crash was on:
RETURN_IF_FAILED(_dxgiFactory2->CreateSwapChainForComposition(_d3dDevice.Get(),
&_swapChainDesc,
nullptr,
&_dxgiSwapChain));in
0:000> k
# Child-SP RetAddr Call Site
00 00000043`cef8ec80 00007ff9`3a4ac5a1 Microsoft_Terminal_Control!Microsoft::Console::Render::DxEngine::_CreateDeviceResources+0x47b [E:\BA\242\s\src\renderer\dx\DxRenderer.cpp @ 630]
01 (Inline Function) --------`-------- Microsoft_Terminal_Control!Microsoft::Console::Render::DxEngine::GetSwapChain+0x14 [E:\BA\242\s\src\renderer\dx\DxRenderer.cpp @ 1010]
02 00000043`cef8ed50 00007ff9`3a55667d Microsoft_Terminal_Control!winrt::Microsoft::Terminal::Control::implementation::ControlCore::GetSwapChain+0x21 [E:\BA\242\s\src\cascadia\TerminalControl\ControlCore.cpp @ 1183]
03 00000043`cef8ed80 00007ff9`3a4e1f71 Microsoft_Terminal_Control!winrt::Microsoft::Terminal::Control::implementation::TermControl::RenderEngineSwapChainChanged$_ResumeCoro$1+0x2bd [E:\BA\242\s\src\cascadia\TerminalControl\TermControl.cpp @ 582]
04 (Inline Function) --------`-------- Microsoft_Terminal_Control!std::experimental::coroutine_handle<void>::resume+0x9 [C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.28.29910\include\experimental\coroutine @ 107]
05 (Inline Function) --------`-------- Microsoft_Terminal_Control!std::experimental::coroutine_handle<void>::operator()+0x9 [C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.28.29910\include\experimental\coroutine @ 99]
06 00000043`cef8ee50 00007ff9`5e2623a6 Microsoft_Terminal_Control!winrt::impl::resume_apartment_callback+0x11 [E:\BA\242\s\src\cascadia\TerminalControl\Generated Files\winrt\windows.ui.core.h @ 1088]
07 00000043`cef8ee80 00007ff9`5e2af93f Windows_UI!<lambda_59517943c03487243f9bea31c6c1a784>::operator()+0x84 [onecoreuap\windows\advcore\winrt\onecoreiwindow\corewindow\common\dispatcher.cpp @ 908]
08 00000043`cef8eeb0 00007ff9`7de6a440 Windows_UI!Microsoft::WRL::Details::DelegateArgTraits<long (__cdecl Windows::System::IDispatcherQueueHandler::*)(void)>::DelegateInvokeHelper<Microsoft::WRL::Implements<Microsoft::WRL::RuntimeClassFlags<2>,Windows::System::IDispatcherQueueHandler,Microsoft::WRL::FtmBase>,<lambda_59517943c03487243f9bea31c6c1a784>,-1>::Invoke+0xf [onecore\external\sdk\inc\wrl\event.h @ 354]
09 00000043`cef8eee0 00007ff9`7de4229c CoreMessaging!Windows::System::DispatcherQueue::DeferInvokeCallback+0x20 [mincore\coreui\dev\dispatcherqueue\wrtdispatcherqueue.cpp @ 903]
0a (Inline Function) --------`-------- CoreMessaging!Microsoft::CoreUI::ActionCallback::ImportAdapter$::__l2::<lambda_a81ff790741c2a62f2197c2561f5fe49>::operator()+0x1f [mincore\CoreUI\Dev\System\Api\IExportMessageSession.cs @ 22]
the _dxgiFactory2 was null. That's unexpected. It shouldn't be null.
- (E) It doesn't seem like we're calling this when we create the automation peer -- we are not guaranteed to always call UpdateSettings after creating a peer, so the first peer may have no padding. See Only access ControlInteractivity through the projection #10051 (comment). (fixed by Initialize the padding for the Control UIA provider #10874)