-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Open
Labels
Area-SettingsIssues related to settings and customizability, for console or terminalIssues related to settings and customizability, for console or terminalIssue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Complex enough to require an in depth planning process and actual budgeted, scheduled work.Product-TerminalThe new Windows Terminal.The new Windows Terminal.
Milestone
Description
Description of the new feature/enhancement
After #8459, we'll have the following scroll actions:
scrollUpscrollDownscrollUpPagescrollDownPagescrollToTopscrollToBottom
This seems to be a case of us introducing new actions when we should be introducing new arguments instead. I propose the following designs:
Design 1: 3 args
- action:
scroll - arguments:
direction: up|downmode: system|page|bufferrowsToScroll: <optional int>
Personally dislike that rowsToScroll only works if you're in "system" mode. But it avoids the override in Design 2.
Design 2: Override mode
- action:
scroll - arguments:
direction: up|downmode: system|page|buffer|<int>
This is basically Design 1, except rowsToScroll is embedded inside mode. If we go with this approach, maybe mode should be renamed to something like "amount"?
Open to discussion. Go!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-SettingsIssues related to settings and customizability, for console or terminalIssues related to settings and customizability, for console or terminalIssue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Complex enough to require an in depth planning process and actual budgeted, scheduled work.Product-TerminalThe new Windows Terminal.The new Windows Terminal.