Skip to content

Polish TabBase #8452

@carlos-zamora

Description

@carlos-zamora

TerminalPage::_RefreshUIForSettingsReload() has a section where it iterates through each tab and updates the settings in one way or another. This can be slightly refactored by...

  • add UpdateSettings to TabBase
  • have the for-loop just call UpdateSettings on each one
  • unify creating a new terminal tab and settings tab

Additional refactor work items can/will be added here as they come up.

Metadata

Metadata

Assignees

Labels

Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIn-PRThis issue has a related PRIssue-TaskIt's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions