-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Closed
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-SettingsIssues related to settings and customizability, for console or terminalIssues related to settings and customizability, for console or terminalHelp WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Description
We've discussed this for a while now, but it's possible now this the other work Carlos is doing with settings.
I've got a WIP branch here: dev/migrie/f/settings-getters-only, with only a few errors.
I think for each of these, the TermControl is going to need to cache a local copy of the value, to represent it's actual runtime value, rather than use the IControlSettings as a buffer.
I'm filing this so someone else can pick that up where I left off.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-SettingsIssues related to settings and customizability, for console or terminalIssues related to settings and customizability, for console or terminalHelp WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.