-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Open
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Help WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.Issue-ScenarioProduct-MetaThe product is the management of the products.The product is the management of the products.
Milestone
Description
I'm gonna use this thread to track things that I think of that probably should be tested, but didn't get a test during the PR for one reason or another. Usually those reasons are
- We don't have a good testing framework in place for something like that
- It's a feature / UI test, which is a lot trickier to author a test for
- It wasn't worth blocking the PR over
I'll add more to this list as I think of them.
Unit Tests
- Hook up the Save and Reset buttons #8348 (comment): If we change the
DefaultProfile, then serialize the settings, it should be serialized as the value we set it to. - Tests for
OSC 9 ; 9, Implement ConEmu's OSC 9;9 to set the CWD #8330 - Test the newline stripping/replacing in Fix multi line paste detection and filtering #8634. Don't really have TermControl tests, so that's something.
- From "Teach flyouts and palette to prefer user bindings over defaults Teach flyouts and palette to prefer user bindings over defaults #8725" - test that looking up a binding for an action returns the last one in the settings file
- Similarly, ensure that the layering multiple files, the lookup returns the value from the last file
- Sanitize paste content by filtering out control chars #8875 filter control characters pasted to the
TermControl - Allow configuring suppressApplicationTitle in new tab/pane/window commands #9392 - test that combining
--suppressApplicationTitle(or in theNewTerminalArgs) works as expected - Fix selection logic with shift on multi-click Fix selection logic with shift on multi-click #9403
- For this we'd need unit tests for a terminal control. What we really need are unit tests for
ControlInteractivity(which wraps the UI-like logic around theControlCore). We could do just unit tests for ControlInteractivity, since that would be UI-independent. Oh but if it's in the same lib as TermControl, then do we have the problem that the TermControl is going to want to link with Resources, and load them at runtime (even if the test doesn't have a TermControl in it?) yikes.
- For this we'd need unit tests for a terminal control. What we really need are unit tests for
- Fix profile name generation to allocate unique name Fix profile name generation to allocate unique name #9816
-
ControlInteractivity::CopySelectionToClipboardreturns false if there's no selection -
ControlInteractivityTests::TestPanWithTouch- does what it says on the label. Never got around to writing it. - Serialize stub for dynamic profiles Serialize stub for dynamic profiles #9964
- Attempt to heal settings files damaged by Sometimes, saving a setting in the UI doesn't actually apply #9962 Attempt to heal settings files damaged by #9962 #10143
- Scrolling up, then trying to send mouse events shouldn't send VT (from Fix mouse coordinates when viewport is scrolled #10642 (comment))
- Fix SSE2 variant of TextColor::GetColor Fix SSE2 variant of TextColor::GetColor #10867
- Monarch methods added in Persist window layout on window close #10972 -
Monarch::SignalClose,Monarch::GetNumberOfPeasants, creating and closing window events - Fix mouse coordinates when viewport is scrolled for all events, not just pressed #11290
- Fix layering of fragment profiles #11325
- Fix crash and empty action in SUI Actions Page #11427
- Fixe arg parsing when one-character argument is followed by
;#13706 - conhost crashes on SetConsoleWindowInfo #5843
- Add --appendCommandLine flag for appending to command #15822 (comment)
- more...
Feature / UI Tests
- Support for navigating panes by MRU #8183 As we move focus though panes, make sure the MRU order is updated
- Support for navigating panes by MRU #8183 Make sure that
exiting the "last" pane, then trying to MRU to it does the right thing (by going to the pane before it) - Support for navigating panes by MRU #8183 Ensure that Pane IDs are assigned sensibly, and are moved correctly when a pane is closed
- Fix next tab activation in focus mode upon tab closing #8549 / Closing a tab in focus mode causes terminal to become unresponsive Closing a tab in focus mode causes terminal to become unresponsive #7916
- how
closeTabshould accept anindexparam #7180 interacts with Teach terminal page to go to the last used tab in MRU mode #8610 - Introduce startupActions in settings Introduce startupActions in settings #8770
- This is a good one. Add a local test for setting startupActions, then verify the layout is as expected
- Make sure that parsing these args with warnings results in warnings being added to the
AppLogic::_warnings- and in the awrning case, that only a single tab is created
- And test that providing args at the commandline will override this setting
- Tests to make sure that closing other tabs works as expected
- Tests to make sure "close tabs after" works as expected
- No idea how to test: "Fix settings not updating on reload Fix settings not updating on reload #9289"
- That one time a fragment extension didn't define a
Publicfolder, so it ended up being null, right around March 12th 2021 - Passing through moveFocus keys when moving to another pane failed #10806
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Help WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.Issue-ScenarioProduct-MetaThe product is the management of the products.The product is the management of the products.