Skip to content

Build fails after commit 62765f1 #4285

@j4james

Description

@j4james

Environment

Windows build number: Version 10.0.18362.535

Any other software?
Visual Studio 2019 version 16.4.2

Steps to reproduce

  1. Checkout commit 62765f1
  2. Rebuild solution from within Visual Studio

Expected behavior

The build should succeed.

Actual behavior

I get the following errors:

Error	LNK2001	unresolved external symbol "public: __cdecl Microsoft::Console::Render::GdiEngine::GdiEngine(void)" (??0GdiEngine@Render@Console@Microsoft@@QEAA@XZ)	UnitTests_TerminalCore	\terminal\src\cascadia\UnitTests_TerminalCore\ConInteractivityWin32Lib.lib(Window.obj)	1	
Error	LNK2001	unresolved external symbol "public: long __cdecl Microsoft::Console::Render::GdiEngine::SetHwnd(struct HWND__ * const)" (?SetHwnd@GdiEngine@Render@Console@Microsoft@@QEAAJQEAUHWND__@@@Z)	UnitTests_TerminalCore	\terminal\src\cascadia\UnitTests_TerminalCore\ConInteractivityWin32Lib.lib(Window.obj)	1	
Error	LNK1120	2 unresolved externals	UnitTests_TerminalCore	\terminal\bin\x64\Release\Terminal.Core.Unit.Tests.dll	1	

If I checkout one revision back (77dd51a), the build succeeds.

Is this just me, or is something busted?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Needs-Tag-FixDoesn't match tag requirementsNeeds-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingResolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions