-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Closed
Labels
Area-AccessibilityIssues related to accessibilityIssues related to accessibilityArea-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-ConhostFor issues in the Console codebaseFor issues in the Console codebaseProduct-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Description
A TODO for after PR #1915
The PR added IRenderData as a parameter to just about all of the static functions. It makes more sense to make them non-static. This will have a propogated effect on some other things on the project, though.
A few architectural changes may need to be made which can be pretty annoying.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-AccessibilityIssues related to accessibilityIssues related to accessibilityArea-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-ConhostFor issues in the Console codebaseFor issues in the Console codebaseProduct-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.