-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Closed
Labels
Area-ServerDown in the muck of API call servicing, interprocess communication, eventing, etc.Down in the muck of API call servicing, interprocess communication, eventing, etc.Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirementsPriority-1A description (P1)A description (P1)Product-ConptyFor console issues specifically related to conptyFor console issues specifically related to conptySeverity-CrashCrashes are real bad news.Crashes are real bad news.
Milestone
Description
Environment
Windows build number: Microsoft Windows [Version 10.0.18362.175]
Any other software? Visual Studio Code Insiders
Steps to reproduce
- Launch VS Code Insiders.
- Ensure using conpty with setting:
terminal.integrated.windowsEnableConpty - Open a terminal with Ctrl+`
- Close the terminal with the trash can icon
- Repeat 3 and 4 until the window hangs. It takes around 10 retries on my machine.
Expected behavior
No hanging.
Actual behavior
The window hangs. Using windbg, I see the following:
Notice the many leftover conhosts in the task manager as well as the hang in ClosePseudoConsole.
Here is the link to the code in node-pty calling into the PseudoConsole API.
https://github.com/microsoft/node-pty/blob/04445ed76f90b4f56a190982ea2d4fcdd22a0ee7/src/win/conpty.cc#L429
/cc @daimms
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-ServerDown in the muck of API call servicing, interprocess communication, eventing, etc.Down in the muck of API call servicing, interprocess communication, eventing, etc.Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirementsPriority-1A description (P1)A description (P1)Product-ConptyFor console issues specifically related to conptyFor console issues specifically related to conptySeverity-CrashCrashes are real bad news.Crashes are real bad news.


