-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Open
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-SettingsIssues related to settings and customizability, for console or terminalIssues related to settings and customizability, for console or terminalIssue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.The new Windows Terminal.
Milestone
Description
ReadUTF8File in the Settings library tries three times to read the settings file. If the size changes while it is being read, it'll try again.
Right now, the code looks like this (roughly):
while(tries) {
open
check permissions
read in full
check read size
}
It's expensive to open the file and check the permissions every time. Instead, we could:
open
check permissions
while (tries) {
reset file pointer
read in full
check read size
}
That'll save us closing/reopening the file up to three times.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-SettingsIssues related to settings and customizability, for console or terminalIssues related to settings and customizability, for console or terminalIssue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.The new Windows Terminal.