Skip to content

POSIX_COMMIT_CHECKS adding for apple. #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mjp41 merged 2 commits into from
Feb 23, 2021
Merged

POSIX_COMMIT_CHECKS adding for apple. #284

mjp41 merged 2 commits into from
Feb 23, 2021

Conversation

@devnexen
Copy link
Collaborator

@devnexen devnexen commented Feb 20, 2021

No description provided.

@mjp41
Copy link
Member

mjp41 commented Feb 21, 2021

@devnexen thanks for thinking about this. You also need the equivalent to

https://github.com/microsoft/snmalloc/blob/master/src/pal/pal_bsd.h#L42-L44

to simulate actually removing the pages from being accessible. This is actually more important than the memset.

@devnexen
Copy link
Collaborator Author

devnexen commented Feb 21, 2021

Yes I know but unfortunately func-malloc* tests abort with it.

@mjp41
Copy link
Member

mjp41 commented Feb 22, 2021

Does it do that if we disable calling the MADV_FREE_REUSABLE, when we have the commit checks on? And remove the converse MADV_FREE_REUSE in that mode too?

@devnexen
Copy link
Collaborator Author

devnexen commented Feb 22, 2021

Unfortunately still does not still work (on Mac M1/ARM it should work on Mac Intel).

@devnexen devnexen force-pushed the posix_commit_checks_apple branch 2 times, most recently from d73e713 to fa14947 Compare February 22, 2021 12:51
@devnexen
Copy link
Collaborator Author

devnexen commented Feb 22, 2021

With actual code both work under Mac Intel and ARM

mjp41
mjp41 requested changes Feb 22, 2021
View reviewed changes
Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me, but Clang format is unhappy
https://dev.azure.com/snmalloc/snmalloc/_build/results?buildId=1308&view=logs&j=fb683405-d979-52da-6de9-2541dff429a6&t=f66a877f-3a0c-5131-ec8c-e97d54dcc0fe

@davidchisnall, any comments?

@devnexen devnexen force-pushed the posix_commit_checks_apple branch from d9311a8 to 54da79f Compare February 22, 2021 13:50
@mjp41 mjp41 merged commit c082a33 into microsoft:master Feb 23, 2021
@amari amari mentioned this pull request Jun 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjp41 mjp41 mjp41 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devnexen @mjp41