.Net: Add AudioTimestamp Property to GeminiPromptExecutionSettings#9526
Merged
rogerbarreto merged 3 commits intomicrosoft:mainfrom Nov 5, 2024
Merged
.Net: Add AudioTimestamp Property to GeminiPromptExecutionSettings#9526rogerbarreto merged 3 commits intomicrosoft:mainfrom
rogerbarreto merged 3 commits intomicrosoft:mainfrom
Conversation
rogerbarreto
approved these changes
Nov 5, 2024
Member
rogerbarreto
left a comment
There was a problem hiding this comment.
LGTM, fix any warnings.
Ensure you test this in existing Integration Tests as well.
dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs
Outdated
Show resolved
Hide resolved
…ettings.cs Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
markwallace-microsoft
approved these changes
Nov 5, 2024
dmytrostruk
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Why is this change required?
This change is required to enhance the functionality of audio processing in the Semantic Kernel by allowing the inclusion of timestamps in audio responses.
What problem does it solve?
It resolves the limitation of missing audio timestamp support in the
GeminiPromptExecutionSettings, which has been a significant blocker for developers trying to utilize audio prompts effectively.What scenario does it contribute to?
This contribution is particularly useful for applications that require precise audio response management, enabling better synchronization and analysis of audio data in real-time scenarios.
If it fixes an open issue, please link to the issue here.
Description
This contribution adds a new feature that allows audio responses to include timestamps, a crucial element for many applications. Here’s a quick overview of what’s been implemented:
New Property: The
AudioTimestampproperty indicates whether the audio response should include timestamps. When enabled, this property will ensure that audio timestamps are included in requests to the model, providing developers with the precise control they need for their applications.Seamless Integration: I conducted a thorough review of the existing codebase to ensure that this new feature integrates smoothly without disrupting current functionalities. This change is designed to be backward-compatible, making it easier for developers to adopt.
Future-Proofing: By adding this property, we’re not just solving an immediate need; we’re also paving the way for future enhancements in audio processing capabilities within the Semantic Kernel framework.
Contribution Checklist