.Net Processes - Update Runtime Exception Handling / Logging#9457
Merged
.Net Processes - Update Runtime Exception Handling / Logging#9457
Conversation
esttenorio
approved these changes
Oct 29, 2024
alliscode
approved these changes
Oct 30, 2024
…t/semantic-kernel into process-runtime-logging
esttenorio
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Throwing and logging exceptions in the runtime is a little verbose. It also creates quite a few conditional arcs for test coverage (or lack there-of). Utility method streamlines this pattern and eliminates all but one conditional arc.
Note: Considered this pattern, opted on favoring the never-null object as the root of the extention method.
Description
LogErroroverride that accepts the exception object.Kernel.LoggingFactory(was previously always null)Verifyasync/awaitfor methods where not required.Contribution Checklist