Improvements/fixes for service registry#857
Merged
shawncal merged 1 commit intomicrosoft:feature-serviceregistryfrom May 8, 2023
Merged
Conversation
dluc
previously requested changes
May 8, 2023
Contributor
dluc
left a comment
There was a problem hiding this comment.
can we discuss these changes before merging?
shawncal
approved these changes
May 8, 2023
Contributor
Just merging into feature branch. Will have a design discussion before bringing to main. |
Dismissing as this is just a feature branch for staging. Design discussing forthcoming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Series of improvements to align service registration extension methods with the other kernel builder ones and remove the "default" suffix from service provider Get*ServiceOrDefault method name to not expose unnecessary details with code that may use it.
Contribution Checklist
dotnet format