Skip to content

.Net: Standardize name 'logger' across the project#2186

Merged
shawncal merged 2 commits intomicrosoft:mainfrom
shawncal:logger-standardize
Jul 26, 2023
Merged

.Net: Standardize name 'logger' across the project#2186
shawncal merged 2 commits intomicrosoft:mainfrom
shawncal:logger-standardize

Conversation

@shawncal
Copy link
Contributor

@shawncal shawncal commented Jul 25, 2023

Description

Throughout the repo, we have a mix of logger and log (plus variations such as Log, _log) used to hold an ILogger instance.

This PR seeks to standardize the name logger, Logger and _logger to represent ILogger object references -- including properties and method parameters -- and Log as the method (action) that the logger can take.

To reviewers, this is a large and extraordinarily mundane PR with many identical substitutions. Please take a closer look at:

  • IKernel.cs
  • Kernel.cs
  • SKContext.cs
    ...as these additionally contain Obsoleted properties.

Contribution Checklist

@shawncal shawncal added .NET Issue or Pull requests regarding .NET code samples ai connector Anything related to AI connectors labels Jul 25, 2023
@shawncal shawncal requested a review from a team as a code owner July 25, 2023 23:25
@shawncal shawncal added docs and tests Improvements or additions to documentation kernel Issues or pull requests impacting the core kernel memory connector and removed samples labels Jul 25, 2023
@shawncal shawncal changed the title Standardize name 'logger' across the project .Net: Standardize name 'logger' across the project Jul 25, 2023
@shawncal shawncal requested a review from stephentoub July 25, 2023 23:25
@shawncal shawncal added the PR: breaking change Pull requests that introduce breaking changes label Jul 25, 2023
@shawncal shawncal added this pull request to the merge queue Jul 26, 2023
Merged via the queue into microsoft:main with commit 6cee23f Jul 26, 2023
@shawncal shawncal deleted the logger-standardize branch July 26, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai connector Anything related to AI connectors docs and tests Improvements or additions to documentation kernel Issues or pull requests impacting the core kernel memory connector .NET Issue or Pull requests regarding .NET code PR: breaking change Pull requests that introduce breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants