.Net: Standardize name 'logger' across the project#2186
Merged
shawncal merged 2 commits intomicrosoft:mainfrom Jul 26, 2023
Merged
.Net: Standardize name 'logger' across the project#2186shawncal merged 2 commits intomicrosoft:mainfrom
shawncal merged 2 commits intomicrosoft:mainfrom
Conversation
stephentoub
approved these changes
Jul 26, 2023
stephentoub
reviewed
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Throughout the repo, we have a mix of
loggerandlog(plus variations such asLog,_log) used to hold anILoggerinstance.This PR seeks to standardize the name
logger,Loggerand_loggerto represent ILogger object references -- including properties and method parameters -- andLogas the method (action) that the logger can take.To reviewers, this is a large and extraordinarily mundane PR with many identical substitutions. Please take a closer look at:
...as these additionally contain Obsoleted properties.
Contribution Checklist
=> This is a breaking change.