Skip to content

Python: Enable pinecone tests to run in CI#1864

Merged
dluc merged 2 commits intomicrosoft:mainfrom
awharrison-28:python/fix_pinecone_test_setup
Jul 5, 2023
Merged

Python: Enable pinecone tests to run in CI#1864
dluc merged 2 commits intomicrosoft:mainfrom
awharrison-28:python/fix_pinecone_test_setup

Conversation

@awharrison-28
Copy link
Contributor

@awharrison-28 awharrison-28 commented Jul 5, 2023

Motivation and Context

The pinecone integration tests can run locally, but not in CI. CI has no way of picking up the pinecone environment.

Pinecone tests rely on the following environment variables in CI:

  • Pinecone__ApiKey
  • Pinecone__Environment

get_pinecone_config in test_pinecone.py currently only accounts for Pinecone__ApiKey

Description

This PR changes the method get_pinecone_config in test_pinecone.py to return the pinecone environment from an environment variable if the tests are being run in CI.

Contribution Checklist

@awharrison-28 awharrison-28 requested a review from a team as a code owner July 5, 2023 22:50
@github-actions github-actions bot added the python Pull requests for the Python Semantic Kernel label Jul 5, 2023
@awharrison-28 awharrison-28 added the bug Something isn't working label Jul 5, 2023
@dluc dluc added this pull request to the merge queue Jul 5, 2023
Merged via the queue into microsoft:main with commit db040e2 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python Pull requests for the Python Semantic Kernel

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants