Skip to content

Removing Copilot Chat from the SK-dotnet.sln#1830

Merged
shawncal merged 1 commit intomicrosoft:mainfrom
shawncal:remove-copilot-sln
Jul 5, 2023
Merged

Removing Copilot Chat from the SK-dotnet.sln#1830
shawncal merged 1 commit intomicrosoft:mainfrom
shawncal:remove-copilot-sln

Conversation

@shawncal
Copy link
Contributor

@shawncal shawncal commented Jul 3, 2023

Motivation and Context

Copilot chat now builds, and generate packages, from its own series of Actions scripts that reference the csproj directly. This project, despite being included in the sln file, is not project-linked to any other (it uses nuget packages instead), nor does it share common dependencies.

Having it in the sln...

  • produces longer build times,
  • raises dependabot updates for copilot changes mislabeled as "...under /dotnet"
  • does not get any copilot test coverage

Description

Removing the Copilot Chat project file from the general SK-dotnet.sln file.
Updating GitHub Actions scripts.

Contribution Checklist

…project-linked and it builds with its own actions scripts
@shawncal shawncal added the .NET Issue or Pull requests regarding .NET code label Jul 3, 2023
@shawncal shawncal requested a review from a team as a code owner July 3, 2023 23:07
@github-actions github-actions bot removed the .NET Issue or Pull requests regarding .NET code label Jul 3, 2023
@gitri-ms
Copy link
Contributor

gitri-ms commented Jul 3, 2023

Should we add a new .sln for Copilot Chat to the repo?

@shawncal
Copy link
Contributor Author

shawncal commented Jul 5, 2023

Should we add a new .sln for Copilot Chat to the repo?

Certainly can -- I don't think it's (currently) necessary, as the cp chat build scripts just use the csproj file as a target, instead of a sln. If there end up being more than one dotnet project, then yes, certainly a solution would be a good idea.

@shawncal shawncal added this pull request to the merge queue Jul 5, 2023
Merged via the queue into microsoft:main with commit 899f94c Jul 5, 2023
@shawncal shawncal deleted the remove-copilot-sln branch July 5, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants