Is the only way to get formatting on vs code to have a jar checked in to the repo?

Is the only way to get formatting on vs code to have a jar checked in to the repo?

Not likely. The plugin/extensions for VSCode likely pull in whatever dependencies you need instead. I'd take a look at .vscode/extensions.json for dictating the recommended extensions for this project.

This was the only true cross-platform way to get Google Java Format with AOSP style to work on VS Code.

Commit 47cf4d0 moves the formatting plugin to the general profile of the Maven project.

This way, no matter when/how the Maven project is built (command-line, terminal, etc), the code will be formatted.

But the VS Code setting is still required as it ensures new code comes with the right formatting, and solves the problem of when a developer adds a Java class without running a build (unlikely, but still...)

We have decided to fix the /spotless PR helper command, and then simply fail the build if the formatting is wrong, and give the PR author and other maintainers to fix formatting with said command.

Meanwhile, IDEs may be configured manually by the developer with the AOSP Google Format style, but that setting doesn't have to be in the repository. We may change the style later, to something that both IntelliJ and VS Code can share certainly (not the case for AOSP).

For now, PR authors should definitely build the project with -Pbug-check before pushing changes.