Python: adding external tokenizer to python text_chunker#1388
Merged
shawncal merged 4 commits intomicrosoft:mainfrom Jul 8, 2023
Merged
Python: adding external tokenizer to python text_chunker#1388shawncal merged 4 commits intomicrosoft:mainfrom
shawncal merged 4 commits intomicrosoft:mainfrom
Conversation
mkarle
approved these changes
Jun 16, 2023
Contributor
|
@gramhagen Cool change! Thanks for the contribution. Welcome to Semantic Kernel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
addressing issue #1387
chunking text should allow use of an external tokenizer
Description
added pass-through of an token counting function, defaulting to the existing _token_counter() method
while fixing a type hint bug I got sucked into making a few changes to clean up the code.
future work would be nice to add chunk overlap functionality similar to langchain's TextSplitter
Contribution Checklist
dotnet format