.Net: Fix: include taskType in Google AI embedding request (fixes #13250)#13277
Merged
rogerbarreto merged 8 commits intomicrosoft:mainfrom Nov 28, 2025
Merged
.Net: Fix: include taskType in Google AI embedding request (fixes #13250)#13277rogerbarreto merged 8 commits intomicrosoft:mainfrom
rogerbarreto merged 8 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
dotnet/src/Connectors/Connectors.Google/Core/GoogleAI/GoogleAIEmbeddingClient.cs
Outdated
Show resolved
Hide resolved
rogerbarreto
approved these changes
Nov 3, 2025
…tiguous tasktype additional property support
Member
|
Important This is an obsoleted service, and we may not support further changes to the service. |
westey-m
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes issue #13250
by ensuring that the Google AI embedding connector correctly includes the taskType field in outgoing requests when EmbeddingGenerationOptions contains a task_type value.
Previously, the connector ignored this field, causing task-specific embeddings (RETRIEVAL_DOCUMENT, RETRIEVAL_QUERY, etc.) to default to generic embeddings.
Description
Changes
Extended GoogleAIEmbeddingRequest.FromData() to include an optional taskType parameter.
Updated GoogleAIEmbeddingClient to extract task_type from EmbeddingGenerationOptions.AdditionalProperties.
Added a new overload in GoogleAITextEmbeddingGenerationService to pass EmbeddingGenerationOptions while maintaining backward compatibility.
Added unit test FromData_Should_Include_TaskType_When_Provided to verify that "taskType" appears correctly in serialized JSON.
Contribution Checklist