Skip to content

.Net & Python: Add tool definitions to agent invoke span#13153

Merged
TaoChenOSU merged 3 commits intomainfrom
taochen/add-tool-definitions-to-agent-invoke-span
Sep 22, 2025
Merged

.Net & Python: Add tool definitions to agent invoke span#13153
TaoChenOSU merged 3 commits intomainfrom
taochen/add-tool-definitions-to-agent-invoke-span

Conversation

@TaoChenOSU
Copy link
Copy Markdown
Contributor

@TaoChenOSU TaoChenOSU commented Sep 19, 2025

Motivation and Context

The current GenAI Semantic Conventions have changed since the last time we modified the agent_invoke span.

Previous PRs: #12940, #12928, #12834

Description

The following changes were made:

  1. gen_ai.agent.invocation_input -> gen_ai.input.messages
  2. gen_ai.agent.invocation_output -> gen_ai.output.messages
  3. Add gen_ai.tool.definitions

.Net:
image

Python:
image

Contribution Checklist

@TaoChenOSU TaoChenOSU self-assigned this Sep 19, 2025
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner September 19, 2025 16:57
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner September 19, 2025 16:57
@moonbox3 moonbox3 added .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel labels Sep 19, 2025
@github-actions github-actions bot changed the title Add tool definitions to agent invoke span Python: Add tool definitions to agent invoke span Sep 19, 2025
@github-actions github-actions bot changed the title Python: Add tool definitions to agent invoke span .Net: Add tool definitions to agent invoke span Sep 19, 2025
@TaoChenOSU TaoChenOSU changed the title .Net: Add tool definitions to agent invoke span .Net & Python: Add tool definitions to agent invoke span Sep 19, 2025
@moonbox3
Copy link
Copy Markdown
Collaborator

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
utils/telemetry/agent_diagnostics
   decorators.py1201190%163, 195, 199, 203, 243–248, 253
   gen_ai_attributes.py80100% 
TOTAL27293477082% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3747 22 💤 0 ❌ 0 🔥 1m 41s ⏱️

@TaoChenOSU TaoChenOSU added this pull request to the merge queue Sep 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2025
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Sep 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2025
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit d455a20 Sep 22, 2025
37 checks passed
@TaoChenOSU TaoChenOSU deleted the taochen/add-tool-definitions-to-agent-invoke-span branch September 22, 2025 17:26
@github-project-automation github-project-automation bot moved this to Sprint: Done in Semantic Kernel Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel telemetry

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants