.Net: SK integration with MEAI Abstractions (Service Selector + Contents) Phase 1#10651
Merged
rogerbarreto merged 31 commits intomicrosoft:feature-msextensions-aifrom Mar 3, 2025
Conversation
stephentoub
reviewed
Feb 24, 2025
dotnet/src/SemanticKernel.Abstractions/AI/ChatClient/ChatClientAIService.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatClient/ChatClientExtensions.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatClient/ChatMessageExtensions.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Services/OrderedAIServiceSelector.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Core/Functions/KernelFunctionFromPrompt.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatClient/ChatClientExtensions.cs
Show resolved
Hide resolved
dmytrostruk
approved these changes
Feb 27, 2025
dotnet/src/IntegrationTests/Connectors/OpenAI/OpenAIChatCompletionTests.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatHistoryExtensions.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Services/IServiceSelector.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.UnitTests/Functions/OrderedAIServiceSelectorTests.cs
Show resolved
Hide resolved
shethaadit
approved these changes
Feb 28, 2025
908333b
into
microsoft:feature-msextensions-ai
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change adds a new
IChatClientSelectorabstraction to work without breaking currentIAIServiceSelectorimplementations.This was necessary because
Kernelnow will be able to resolveIChatClients which are notIAIServiceimplementations, andOrderedAIServiceSelectornow can select not onlyAIServicesbutChatClientsas well by implementing theIChatClientSelectorinterface.All other changes are related to test accepting
IChatClients added to theServiceDI container, ensuring they work as expected together with currentIChatCOmpletionServiceandITextGenerationServicein theKernel.