Skip to content

Use core.gvfs#65

Merged
derrickstolee merged 1 commit intomicrosoft:masterfrom
derrickstolee:core.gvfs
Aug 16, 2019
Merged

Use core.gvfs#65
derrickstolee merged 1 commit intomicrosoft:masterfrom
derrickstolee:core.gvfs

Conversation

@derrickstolee
Copy link
Contributor

This was fallout from #38.

See #64 for more discussion on the future of this setting.

Signed-off-by: Derrick Stolee <stolee@gmail.com>
@derrickstolee
Copy link
Contributor Author

/azp run macOS_FunctionalTests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@derrickstolee
Copy link
Contributor Author

/azp run microsoft.scalar (macOS_FunctionalTests)

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@derrickstolee
Copy link
Contributor Author

/azp run microsoft.scalar

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@derrickstolee derrickstolee requested a review from jrbriggs August 16, 2019 14:24
Copy link
Member

@jrbriggs jrbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only question is why you had to manually kick the functions tests multiple times?

@derrickstolee
Copy link
Contributor Author

Only question is why you had to manually kick the functions tests multiple times?

I had to kick the tests once, I just did it wrong multiple times.

The once was because the Mac functional tests timed out. Seems to be related to the LooseObjectsStepTests again (that I thought I fixed in #56), so I'll keep an eye on that.

@derrickstolee derrickstolee merged commit 607dd0f into microsoft:master Aug 16, 2019
@derrickstolee derrickstolee deleted the core.gvfs branch November 18, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants