Update stale 'brew cask' references and other cleanups#487
Merged
derrickstolee merged 4 commits intomicrosoft:mainfrom Mar 11, 2021
Merged
Update stale 'brew cask' references and other cleanups#487derrickstolee merged 4 commits intomicrosoft:mainfrom
derrickstolee merged 4 commits intomicrosoft:mainfrom
Conversation
Homebrew updated their CLI around interacting with casks, and we missed this one. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
This is leftover from removing Scalar.Service from the macOS version. If we install a latest version via 'brew install --cask scalar[-azrepos]' without the existing service registered, it will fail to stop the service that is not running. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
jeffhostetler
approved these changes
Mar 11, 2021
a9b7bf0 to
b7cd08e
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brew updated their CLI. Hence,
scalar upgradeis currently broken. Users will need to runbrew upgrade --cask scalar[-azrepos]to upgrade to a version including this fix.Further, since #458 dropped the Scalar service, the next upgrade will fail because the service is still registered, just not running. Relax the conditions there.
I was also getting build failures locally around the internal verb parameters. They are no longer used, so just drop them. Keep the command-line reference around so we don't break compat with any potential consumers.