Skip to content

mention background maintenance in Git 2.30.0#475

Merged
derrickstolee merged 4 commits intomainfrom
linux-background-maintenance
Feb 2, 2021
Merged

mention background maintenance in Git 2.30.0#475
derrickstolee merged 4 commits intomainfrom
linux-background-maintenance

Conversation

@vtbassmatt
Copy link
Member

@vtbassmatt vtbassmatt commented Jan 13, 2021

No description provided.

@vtbassmatt vtbassmatt requested a review from mjcheetham January 13, 2021 20:53
derrickstolee
derrickstolee approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little nit about the optionality of our custom Git fork. Feel free to modify however you want and merge when you're ready.

vtbassmatt and others added 2 commits January 14, 2021 10:09
@vtbassmatt @derrickstolee
Update Readme.md
f93b6b8 
Co-authored-by: Derrick Stolee <dstolee@microsoft.com>
@vtbassmatt
mention GVFS protocol
56a195a
@vtbassmatt
Copy link
Member Author

vtbassmatt commented Jan 14, 2021

Well, I doubt this README change introduced a bug, but I can't get the ubuntu-16.04 leg to pass. An admin can feel free to override and slam this in on my behalf 😉

@derrickstolee
Copy link
Contributor

derrickstolee commented Jan 14, 2021

Well, I doubt this README change introduced a bug, but I can't get the ubuntu-16.04 leg to pass. An admin can feel free to override and slam this in on my behalf 😉

error: post: (curl:35) SSL connect error [hard_fail]: from POST

Yeah, this is the trickiest kind of test flakiness. Sometimes one of the many clones we do doesn't work.

@vtbassmatt
Copy link
Member Author

vtbassmatt commented Feb 2, 2021

@mjcheetham do you mind overriding the failing CI on this? I very much doubt that a Markdown change breaks things 😉

@derrickstolee
Copy link
Contributor

derrickstolee commented Feb 2, 2021

@mjcheetham do you mind overriding the failing CI on this? I very much doubt that a Markdown change breaks things 😉

I can take care of it. I've been re-running your jobs a few times today. I'm a bit frustrated by the amount of flakiness here...

@derrickstolee derrickstolee merged commit f520d8d into main Feb 2, 2021
@vtbassmatt vtbassmatt deleted the linux-background-maintenance branch February 2, 2021 15:28
@vtbassmatt
Copy link
Member Author

vtbassmatt commented Feb 2, 2021 •
edited
Loading

Seeing the job failure messages is what reminded me this never landed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derrickstolee derrickstolee derrickstolee approved these changes

@mjcheetham mjcheetham Awaiting requested review from mjcheetham

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtbassmatt @derrickstolee