GitProcess: foreground fetch should be interactive#464
Merged
derrickstolee merged 1 commit intomicrosoft:mainfrom Nov 24, 2020
Merged
GitProcess: foreground fetch should be interactive#464derrickstolee merged 1 commit intomicrosoft:mainfrom
derrickstolee merged 1 commit intomicrosoft:mainfrom
Conversation
The foreground fetch was created by copy/pasting from background fetch. We didn't notice any problems because users were authenticating via the /gvfs/config endpoint in most cases. Also, if there was an existing credential, then they would not hit this issue. Resolves microsoft#463. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
c760f29 to
df7388d
Compare
mjcheetham
approved these changes
Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The foreground fetch was created by copy/pasting from background
fetch. We didn't notice any problems because users were authenticating
via the /gvfs/config endpoint in most cases. Also, if there was an
existing credential, then they would not hit this issue.
Resolves #463.