RunVerb: pass git features to ConfigStep#451
Merged
derrickstolee merged 1 commit intomicrosoft:mainfrom Oct 16, 2020
Merged
Conversation
The ConfigStep makes a decision about calling 'git maintenance start' depending on the platform (Linux only for now) and the Git version. However, the code for computing the feature flags is in ScalarVerb and needs to be injected by passing it through the ConfigStep constructor. This was missed in the earlier work that inserted this into other maintenance steps. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
mjcheetham
approved these changes
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ConfigStep makes a decision about calling 'git maintenance start'
depending on the platform (Linux only for now) and the Git version.
However, the code for computing the feature flags is in ScalarVerb and
needs to be injected by passing it through the ConfigStep constructor.
This was missed in the earlier work that inserted this into other
maintenance steps.
This fixes a feature that should have been introduced in #398.