Respect remote default branch name on vanilla Git clone#449
Merged
mjcheetham merged 1 commit intomicrosoft:mainfrom Oct 15, 2020
Merged
Respect remote default branch name on vanilla Git clone#449mjcheetham merged 1 commit intomicrosoft:mainfrom
mjcheetham merged 1 commit intomicrosoft:mainfrom
Conversation
dscho
approved these changes
Oct 15, 2020
Member
dscho
left a comment
There was a problem hiding this comment.
I only had one minor suggestion, and would even be fine with the PR as-is.
Contributor
Ah! This is why this has worked for the Windows and Office customers. Thanks for discovering this! |
derrickstolee
approved these changes
Oct 15, 2020
Attempt to determine the remote's default branch name when performing a `scalar clone` using the vanilla Git protocols (not using the GVFS helper). Use ls-remote to lookup the HEAD ref on the remote, and parse the results. If the remote's HEAD is not a branch, or we fail to parse the output for any reason, consult Git itself for the default branch name as a fallback.
0150798 to
3c267a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to determine the remote's default branch name when performing a
scalar cloneusing the vanilla Git protocols (not using the GVFS helper).Use
ls-remoteto lookup theHEADref on the remote, and parse the results. If the remote'sHEADis not a branch, or we fail to parse the output for any reason, consult Git itself for the default branch name as a fallback.Scalar clones using the GVFS protocol & helper work differently, and already take the default remote branch name from the manual call to
/info/refs?service=git-upload-pack.Fixes #438