Allow functional tests to use Git from $PATH#419
Merged
chrisd8088 merged 2 commits intomicrosoft:mainfrom Aug 18, 2020
Merged
Conversation
derrickstolee
approved these changes
Aug 17, 2020
We implement the equivalent of the existing --test-scalar-on-path functional test command-line option for Git also, namely by adding a new --test-git-on-path option. This permits the execution of the functional test suite on systems where the default installation of Git may not be sufficient to support Scalar.
Per PR review from @derrickstolee.
0fe93e9 to
1231d16
Compare
Contributor
Author
|
/azp run microsoft.scalar (macOS Functional Test (with Watchman)) |
|
Commenter does not have sufficient privileges for PR 419 in repo microsoft/scalar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We implement the equivalent of the existing
--test-scalar-on-pathfunctional test command-line option for Git also, namely by adding a new--test-git-on-pathoption.This permits the manual execution of the functional test suite on systems where the default installation of Git may not be sufficient to support Scalar; e.g., it may be an older version or not the Microsoft Git custom package.
The existing CI jobs are not affected by this change as the default when the new command-line option is not provided is to continue to look for Git as
C:\Program Files\Git\cmd\git.exeon Windows and/usr/local/bin/giton macOS, as the functional test program did before.